Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: rename vm.Module to vm.SourceTextModule #22007

Merged
merged 1 commit into from
Jul 31, 2018
Merged

vm: rename vm.Module to vm.SourceTextModule #22007

merged 1 commit into from
Jul 31, 2018

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Jul 28, 2018

Should have always been named SourceTextModule

/cc @nodejs/vm

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@devsnek devsnek added the vm Issues and PRs related to the vm subsystem. label Jul 28, 2018
@nodejs-github-bot
Copy link
Collaborator

@devsnek build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/369/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. process Issues and PRs related to the process subsystem. vm Issues and PRs related to the vm subsystem. labels Jul 28, 2018
@devsnek
Copy link
Member Author

devsnek commented Jul 28, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/16045/

@targos
Copy link
Member

targos commented Jul 28, 2018

Is it in preparation for adding other kinds of modules?

@devsnek
Copy link
Member Author

devsnek commented Jul 28, 2018 •
edited
Loading

@targos mostly... even if the spec doesn't define any more types we should still name them correctly.

@cjihrig cjihrig added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 28, 2018
cjihrig
cjihrig approved these changes Jul 28, 2018
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No opinion on the change, but the code LGTM.

@targos
Copy link
Member

targos commented Jul 28, 2018

It doesn't have to be semver major. The API is experimental and behind a flag

@TimothyGu TimothyGu removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 28, 2018
@addaleax
Copy link
Member

Not that you have to, but can you explain this? What kind of ES modules would not have some kind of source text associated with them? If this is to distinguish from e.g. WASM modules or so, maybe referring to the used language might be better?

(Also, fyi: @nodejs/modules)

@TimothyGu
Copy link
Member

TimothyGu commented Jul 28, 2018 •
edited
Loading

@addaleax At the last TC39 meeting, a new type of Module Records backed by JavaScript source called Dynamic Module Records was discussed, and it is now at Stage 1. Regardless of whether that proposal makes it all the way into the spec, SourceTextModule is indeed a more descriptive and accurate name for what this class represents.

@TimothyGu
Copy link
Member

@devsnek Would also be nice if my last comment (#22007 (comment)) is integrated into the commit message body.

@devsnek
Copy link
Member Author

devsnek commented Jul 29, 2018

@TimothyGu will do when I land 👍

mcollina
mcollina approved these changes Jul 29, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos
Copy link
Member

targos commented Jul 29, 2018

Resumed: https://ci.nodejs.org/job/node-test-pull-request/16057/

@devsnek
vm: rename vm.Module to vm.SourceTextModule
2bdcdfc 
At the last TC39 meeting, a new type of Module Records backed by
JavaScript source called Dynamic Module Records was discussed, and
it is now at Stage 1. Regardless of whether that proposal makes it
all the way into the spec, SourceTextModule is indeed a more
descriptive and accurate name for what this class represents.

PR-URL: nodejs#22007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
@devsnek devsnek force-pushed the rename-vm-module branch from 62adcd3 to 2bdcdfc Compare July 31, 2018 15:24
@devsnek devsnek closed this Jul 31, 2018
@devsnek devsnek merged commit 2bdcdfc into nodejs:master Jul 31, 2018
@devsnek devsnek deleted the rename-vm-module branch July 31, 2018 15:25
@devsnek
Copy link
Member Author

devsnek commented Jul 31, 2018

landed in 2bdcdfc

targos pushed a commit that referenced this pull request Aug 1, 2018
@devsnek @targos
vm: rename vm.Module to vm.SourceTextModule
9a88fe4 
At the last TC39 meeting, a new type of Module Records backed by
JavaScript source called Dynamic Module Records was discussed, and
it is now at Stage 1. Regardless of whether that proposal makes it
all the way into the spec, SourceTextModule is indeed a more
descriptive and accurate name for what this class represents.

PR-URL: #22007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
@targos targos mentioned this pull request Aug 1, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
@refack refack mentioned this pull request Oct 18, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jkrems jkrems jkrems approved these changes

@jasnell jasnell jasnell approved these changes

@bmeck bmeck bmeck approved these changes

@mcollina mcollina mcollina approved these changes

@ljharb ljharb ljharb approved these changes

@jdalton jdalton jdalton approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. process Issues and PRs related to the process subsystem. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.